From 81a8e4e4cac371b79624c643fa51d6a61e4d4697 Mon Sep 17 00:00:00 2001
From: Laurent Gomila <laurent.gom@gmail.com>
Date: Sun, 15 Mar 2015 14:44:16 +0100
Subject: [PATCH] Fixed potential buffer overflow in SoundFileReaderWav
---
src/SFML/Audio/SoundFileReaderWav.cpp | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/SFML/Audio/SoundFileReaderWav.cpp b/src/SFML/Audio/SoundFileReaderWav.cpp
index 4fe67afe..df8fb98b 100644
--- a/src/SFML/Audio/SoundFileReaderWav.cpp
+++ b/src/SFML/Audio/SoundFileReaderWav.cpp
@@ -232,8 +232,7 @@ bool SoundFileReaderWav::parseHeader(Info& info)
// Skip potential extra information (should not exist for PCM)
if (subChunkSize > 16)
{
- char buffer[1024];
- if (m_stream->read(buffer, subChunkSize - 16) != subChunkSize - 16)
+ if (m_stream->seek(m_stream->tell() + subChunkSize - 16) == -1)
return false;
}
}
@@ -252,8 +251,7 @@ bool SoundFileReaderWav::parseHeader(Info& info)
else
{
// unknown chunk, skip it
- char buffer[1024];
- if (m_stream->read(buffer, subChunkSize) != subChunkSize)
+ if (m_stream->seek(m_stream->tell() + subChunkSize) == -1)
return false;
}
}