From 5ad46c8c7ffd820dae882e28a4abdb3fb683b275 Mon Sep 17 00:00:00 2001
From: krippix <krippix@users.noreply.github.com>
Date: Mon, 5 Jun 2023 20:52:19 +0200
Subject: [PATCH] fixed check if note was played correctly

---
 html/assets/scripts/practice.js | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/html/assets/scripts/practice.js b/html/assets/scripts/practice.js
index 640b441..94ab50f 100644
--- a/html/assets/scripts/practice.js
+++ b/html/assets/scripts/practice.js
@@ -22,6 +22,7 @@ class Task {
 
     generateTask() {
         this.retrieve_settings();
+        this.success = false;
         if (this.chord) {
             this.generateChord();
         } else {
@@ -119,14 +120,23 @@ class Task {
      * Checks if activeKeys fulfill current task
      */
     checkActiveKeys() {
+        let failed = false;
         this.activeKeys.forEach( key => {
-            if (!(key in this.solution)) {
+            if (!(this.solution.includes(key))) {
                 this.result_fail();
-                return;
+                console.log("failed key: "+key);
+                failed = true;
             }
         });
+        if (failed) {
+            console.log("should have pressed: "+this.solution);
+            console.log("actually pressed: "+this.activeKeys);
+            return;
+        }
         if (this.activeKeys.length == this.solution.length) {
             if (Date.now() - this.starttime <= 500) {
+                console.log(this.solution);
+                console.log(this.activeKeys);
                 this.result_success();
                 return;
             } else {