lauchmelder/BloodMagic
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Sanity check pos passed by client

Browse source 
Prevents malicious clients from loading arbitrary chunks.

Thanks to @pau101 for spotting it.
This commit is contained in:
Nicholas Ignoffo 2017-04-30 17:20:17 -07:00
parent 09bab4fca0
commit 7c19e2e2d2
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/main/java/WayofTime/bloodmagic/network/ItemRouterAmountPacketProcessor.java
View file

@ -67,6 +67,9 @@ public class ItemRouterAmountPacketProcessor implements IMessage, IMessageHandle
World world = DimensionManager.getWorld(dimension); World world = DimensionManager.getWorld(dimension);
if (world != null) if (world != null)
{ {
if (!world.isBlockLoaded(pos))
return;
TileEntity tile = world.getTileEntity(pos); TileEntity tile = world.getTileEntity(pos);
if (tile instanceof TileFilteredRoutingNode) if (tile instanceof TileFilteredRoutingNode)
{ {

3
src/main/java/WayofTime/bloodmagic/network/ItemRouterButtonPacketProcessor.java
View file

@ -63,6 +63,9 @@ public class ItemRouterButtonPacketProcessor implements IMessage, IMessageHandle
World world = DimensionManager.getWorld(dimension); World world = DimensionManager.getWorld(dimension);
if (world != null) if (world != null)
{ {
if (!world.isBlockLoaded(pos))
return;
TileEntity tile = world.getTileEntity(pos); TileEntity tile = world.getTileEntity(pos);
if (tile instanceof TileFilteredRoutingNode) if (tile instanceof TileFilteredRoutingNode)
{ {